Add description to Schema #466
Conversation
It looks like the string literal style for descriptions in the schema language is becoming the standard. Sources: - graphql/graphql-spec#466 - https://stackoverflow.com/questions/39962867/how-do-i-add-a-description-to-a-field-in-graphql-schema-language - https://medium.com/apollo-stack/all-you-need-to-know-about-graphql-js-0-7-921e75dd7fd1#.t9csdknur
IvanGoncharov
force-pushed
the
schemaDescription
branch
from
7321fc2
to
9ef2bc4
Compare
|
Approved in the last WG meeting |
leebyron
added
🏁 Accepted (RFC 3)
|
@IvanGoncharov I'm going to leave this as Draft instead of Accepted until there are GraphQL.js changes to match! |
IvanGoncharov
force-pushed
the
schemaDescription
branch
from
4d19603
to
63307d9
Compare
IvanGoncharov
force-pushed
the
schemaDescription
branch
from
63307d9
to
99aff8d
Compare
|
@IvanGoncharov I'm going to rebase this PR. I think all looks great here with the only thing holding it back from Stage 3 is support in the reference implementation. Do you want to write a PR for that? |
|
Actually you need to grant me permission to your branch/PR unless you'd like to rebase this yourself :) |
IvanGoncharov
force-pushed
the
schemaDescription
branch
from
99aff8d
to
d034049
Compare
I update PR. But it's probably because my fork is still against
Yes, I will work on it next week. |
|
@IvanGoncharov any updates on a reference implementation PR for this? |
|
@leebyron Working on it at the moment. |
leebyron
added
🏁 Accepted (RFC 3)
See spec change: graphql/graphql-spec#466
* Add description to schema See spec change: graphql/graphql-spec#466 * Update builtin types according to spec * Render schema description in SDL for SDL/macro schemas
Fist comment is just put
Descriptionsection beforeSchemasection.Changes to review: bd5cdd8
This PR adds description to schema both in SDL and introspection.